[riot-notifications] [RIOT-OS/RIOT] cpu/efm32: add coretemp driver (#15461)

Bas Stottelaar notifications at github.com
Wed Nov 18 16:08:54 CET 2020


@basilfx commented on this pull request.



> @@ -0,0 +1,17 @@
+BOARD ?= sltb001a
+include ../Makefile.tests_common
+
+BOARD_WHITELIST := ikea-tradfri \

> Too bad this got merged so fast without a proper analysis of the situation IMHO.

I must admit that I have missed #11693. As I see, the difference is that #11693 provides a peripheral for reading the internal temperature, where this provides a driver on top of the ADC peripheral.

> so we don't have to re-define this for every board.

We do have to define this for every board, since you don't know which `ADC_LINE` is used for the internal temperature sensor (if defined at all).


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15461#discussion_r526161110
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201118/2a23ea0e/attachment.htm>


More information about the notifications mailing list