[riot-notifications] [RIOT-OS/RIOT] riotboot: don't always return error in riotboot_flashwrite_finish_raw() (#15469)

Francisco notifications at github.com
Wed Nov 18 16:24:34 CET 2020


@fjmolinas commented on this pull request.



> @@ -155,8 +155,6 @@ int riotboot_flashwrite_finish_raw(riotboot_flashwrite_t *state,
 {
     assert(len <= FLASHPAGE_SIZE);
 
-    int res = -1;
-
     uint8_t *slot_start = (uint8_t *)riotboot_slot_get_hdr(state->target_slot);
 
 #if CONFIG_RIOTBOOT_FLASHWRITE_RAW

Hmm looking at this if `CONFIG_RIOTBOOT_FLASHWRITE_RAW` is set there is no verification that the content was written correctly, shouldn't we rename `flashpage_write_and_verify` to `flashpage_write_and_verify_page` and then add `flashpage_write_and_verify` to write and verify? Maybe you planned for this in a later stage @bergzand ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15469#pullrequestreview-533558455
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201118/fcf00f92/attachment.htm>


More information about the notifications mailing list