[riot-notifications] [RIOT-OS/RIOT] riotboot: don't always return error in riotboot_flashwrite_finish_raw() (#15469)

benpicco notifications at github.com
Wed Nov 18 17:48:16 CET 2020


@benpicco commented on this pull request.



> @@ -155,8 +155,6 @@ int riotboot_flashwrite_finish_raw(riotboot_flashwrite_t *state,
 {
     assert(len <= FLASHPAGE_SIZE);
 
-    int res = -1;
-
     uint8_t *slot_start = (uint8_t *)riotboot_slot_get_hdr(state->target_slot);
 
 #if CONFIG_RIOTBOOT_FLASHWRITE_RAW

`flashpage_write()` is also a `void` function, so no error will be reported. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15469#discussion_r526241537
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201118/3c957d76/attachment.htm>


More information about the notifications mailing list