[riot-notifications] [RIOT-OS/RIOT] MQTT-SN Clients ( Emcute/ Asymcute) : Kconfig Updates (#15240)

Leandro Lanzieri notifications at github.com
Thu Nov 19 09:32:32 CET 2020


@leandrolanzieri commented on this pull request.

Small comment, please squash directly

> @@ -38,3 +37,8 @@ ethos:
 	$(Q)env -u CC -u CFLAGS $(MAKE) -C $(RIOTTOOLS)/ethos
 
 include $(RIOTBASE)/Makefile.include
+
+# Set CONFIG_EMCUTE_TOPIC_MAXLEN via CFLAGS if not being set via Kconfig.
+ifndef CONFIG_EMCUTE_TOPIC_MAXLEN
+  CFLAGS += -DCONFIG_EMCUTE_TOPIC_MAXLEN="249"   # 256 - 7

I believe this does not need quotes
```suggestion
  CFLAGS += -DCONFIG_EMCUTE_TOPIC_MAXLEN=249   # 256 - 7
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15240#pullrequestreview-534174164
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201119/e0fc694a/attachment.htm>


More information about the notifications mailing list