[riot-notifications] [RIOT-OS/RIOT] Makefile.include: only include serial.inc.mk on term targets (#15477)

Alexandre Abadie notifications at github.com
Fri Nov 20 08:16:53 CET 2020

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description

This is done after all boards/cpu Makefile.includes are parsed so any board specific serial port (PORT_LINUX/PORT_DARWIN), default terminal (RIOT_TERMINAL) are already defined by the boards.

Then (unconditionally) including `serial.inc.mk` in the board code is not needed anymore, so this PR also removed all these includes.

The idea behind this PR is to have a declarative-like way of configuring the serial at board level. The main Makefile.include should be responsible of determining if the serial (or programmer, or emulator) logic should be included or not and there's already a common serial makefile. So this keeps a good flexibility while reducing code duplication.

Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure

- Green Murdock
- term and cleanterm targets should still work (tested on nucleo-l412kb and adafruit-clue)

Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references

Had this idea while reviewing #15459 (in #15459 (comment) exactly)

Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Makefile.include: only include serial.inc.mk with term targets
  * boards: remove include of serial.inc.mk

-- File Changes --

    M Makefile.include (5)
    M boards/b-l072z-lrwan1/Makefile.include (3)
    M boards/b-l475e-iot01a/Makefile.include (3)
    M boards/cc1312-launchpad/Makefile.include (3)
    M boards/cc1352-launchpad/Makefile.include (3)
    M boards/cc1352p-launchpad/Makefile.include (3)
    M boards/cc2650-launchpad/Makefile.include (3)
    M boards/cc2650stk/Makefile.include (3)
    M boards/common/arduino-due/Makefile.include (3)
    M boards/common/arduino-mkr/Makefile.include (3)
    M boards/common/atmega/Makefile.include (1)
    M boards/common/cc2538/Makefile.include (3)
    M boards/common/esp32/Makefile.include (1)
    M boards/common/esp8266/Makefile.include (1)
    M boards/common/frdm/Makefile.include (3)
    M boards/common/iotlab/Makefile.include (1)
    M boards/common/msb-430/Makefile.include (2)
    M boards/common/msba2/Makefile.include (1)
    M boards/common/nrf51/Makefile.include (3)
    M boards/common/nrf52/Makefile.include (3)
    M boards/common/slwstk6000b/Makefile.include (3)
    M boards/common/sodaq/Makefile.include (3)
    M boards/ek-lm4f120xl/Makefile.include (3)
    M boards/f4vi1/Makefile.include (3)
    M boards/feather-m0/Makefile.include (3)
    M boards/feather-nrf52840/Makefile.include (2)
    M boards/fox/Makefile.include (3)
    M boards/hamilton/Makefile.include (1)
    M boards/hifive1/Makefile.include (3)
    M boards/hifive1b/Makefile.include (3)
    M boards/i-nucleo-lrwan1/Makefile.include (3)
    M boards/ikea-tradfri/Makefile.include (3)
    M boards/im880b/Makefile.include (3)
    M boards/limifrog-v1/Makefile.include (3)
    M boards/lobaro-lorabox/Makefile.include (3)
    M boards/lsn50/Makefile.include (3)
    M boards/maple-mini/Makefile.include (3)
    M boards/mbed_lpc1768/Makefile.include (3)
    M boards/mulle/Makefile.include (3)
    M boards/nz32-sc151/Makefile.include (3)
    M boards/opencm904/Makefile.include (2)
    M boards/p-l496g-cell02/Makefile.include (3)
    M boards/pba-d-01-kw2x/Makefile.include (3)
    M boards/pic32-wifire/Makefile.include (1)
    M boards/pinetime/Makefile.include (1)
    M boards/pyboard/Makefile.include (3)
    M boards/ruuvitag/Makefile.include (2)
    M boards/seeeduino_arch-pro/Makefile.include (3)
    M boards/sensebox_samd21/Makefile.include (3)
    M boards/slstk3401a/Makefile.include (3)
    M boards/slstk3402a/Makefile.include (3)
    M boards/sltb001a/Makefile.include (3)
    M boards/slwstk6220a/Makefile.include (3)
    M boards/spark-core/Makefile.include (2)
    M boards/stk3200/Makefile.include (3)
    M boards/stk3600/Makefile.include (3)
    M boards/stk3700/Makefile.include (3)
    M boards/stm32f0discovery/Makefile.include (3)
    M boards/stm32f3discovery/Makefile.include (3)
    M boards/stm32f429i-disc1/Makefile.include (3)
    M boards/stm32f4discovery/Makefile.include (3)
    M boards/stm32f723e-disco/Makefile.include (3)
    M boards/stm32f769i-disco/Makefile.include (3)
    M boards/stm32l0538-disco/Makefile.include (3)
    M boards/stm32l476g-disco/Makefile.include (3)
    M boards/stm32mp157c-dk2/Makefile.include (3)
    M boards/teensy31/Makefile.include (3)
    M boards/telosb/Makefile.include (1)
    M boards/thingy52/Makefile.include (2)
    M boards/ublox-c030-u201/Makefile.include (3)
    M boards/z1/Makefile.include (2)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201119/41c3404d/attachment-0001.htm>

More information about the notifications mailing list