[riot-notifications] [RIOT-OS/RIOT] pkg/lwip / pkg/tinydtls: use new mbox_avail() / mbox_unset() function. (#15484)

Martine Lenders notifications at github.com
Fri Nov 20 15:05:23 CET 2020


@miri64 commented on this pull request.



> @@ -185,6 +185,17 @@ static inline size_t mbox_avail(mbox_t *mbox)
     return cib_avail(&mbox->cib);
 }
 
+/**
+ * @brief   Unset's the mbox, effectively deinitializing invalidating it.

> Why is this needed?

Scroll the code and you see, that lwIP requires a way to invalidate their mboxes and check the validiy.

https://github.com/RIOT-OS/RIOT/blob/dd1de91c636bc98956bc40fd904df2ee4b213ed2/pkg/lwip/include/arch/sys_arch.h#L101-L111

I agree that the current approach is not the correct one, maybe. Any idea how we should proceed with that?


> (I suggest splitting, the other changes were already ACKed...)

Can do.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15484#discussion_r527711410
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201120/210d26d4/attachment-0001.htm>


More information about the notifications mailing list