[riot-notifications] [RIOT-OS/RIOT] Bugfix/sfr04 avr overflow (#15494)

Wouter Symons notifications at github.com
Mon Nov 23 09:14:58 CET 2020


I agree that int should be replaced here by uint32_t, as the patch does. So in any case: this patch is a good improvement. I'm not disputing that at all!

I was simply curious if it also actually fixes the bug it's trying to fix. (The Issue is not linked, but OP mentioned [here](https://github.com/RIOT-OS/RIOT/issues/13079#issuecomment-731810806) that he fixed it and was going to make a PR)

@gdiribarne : did you also change the stacksize, in order for it to work?

You said:
> @kaspar030 had a good solution which consists in adapting the int32_t distance inside the sfr04_dev structure.

But it was haukepetersen who suggested changing the datalength of the int. Kaspar suggested trying to increase the stacksize. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15494#issuecomment-732001114
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201123/aa5374c6/attachment.htm>


More information about the notifications mailing list