[riot-notifications] [RIOT-OS/RIOT] docker: pass number of jobs from MAKEFLAGS to the container (#15196)

Francisco notifications at github.com
Mon Nov 23 11:25:43 CET 2020


@fjmolinas commented on this pull request.



> @@ -104,6 +104,15 @@ DOCKER_MAKE_ARGS ?=
 # https://github.com/docker/for-mac/issues/2396
 ETC_LOCALTIME = $(realpath /etc/localtime)
 
+# Fetch the number of jobs from the MAKEFLAGS
+# With $MAKE_VERSION < 4.2, the amount of parallelism is not available in
+# $MAKEFLAGS, only that parallelism is requested. So only -j, even if
+# something like -j3 is specified. This can be unexpected and dangerous
+# in older make so don't enable parallelism if $MAKE_VERSION < 4.2
+MAKE_JOBS_NEEDS = 4.1.999
+MAKE_VERSION_OK = $(call version_is_greater,$(MAKE_VERSION),$(MAKE_JOBS_NEEDS))

Maybe we should use `memoized` here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15196#pullrequestreview-536338449
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201123/a8063b03/attachment.htm>


More information about the notifications mailing list