[riot-notifications] [RIOT-OS/RIOT] boards: move programmer includes in Makefile.include (#15475)

Alexandre Abadie notifications at github.com
Tue Nov 24 14:44:02 CET 2020


@aabadie commented on this pull request.



> @@ -43,14 +43,8 @@ ifeq ($(PROGRAMMER),)
 endif
 
 ifeq ($(PROGRAMMER),edbg)
-  # use edbg for flashing
+  # use edbg for flashing. must be included before openocd

Here I think that `openocd.inc.mk` could be included at the end of `edbg.inc.mk` instead of here. And then we could drop all the logic used here.
That would work because: FLASHER will be defined first for edbg and DEBUGGER/DEBUGSERVER variables will be defined after by code in openocd.inc.mk. FLASHER won't be reset since it uses `?=` in `openocd.inc.mk`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15475#pullrequestreview-537502929
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201124/5dbaa319/attachment-0001.htm>


More information about the notifications mailing list