[riot-notifications] [RIOT-OS/RIOT] sys/entropy_source: add new module for entropy sources (#14324)
notifications at github.com
Wed Nov 25 11:53:08 CET 2020
@leandrolanzieri commented on this pull request.
> + * Although APIs between multiple entropy sources might be similar, every source has to define its
+ * own API to be open for specific requirements. Entropy sources are crucial, thus, separate APIs should
+ * make the choice for one or the other explicit. Furthermore, multiple sources should be able to run in parallel
+ * and separate APIs simplify access (source management).
I agree that a common API in the case of entropy sources seems beneficial, and the distinction that @maribu makes between the types of entropy sources sounds reasonable. With this in mind, I also have to say, that I would not like for us to rush into an API that seems to cover the couple of use-cases that we can think of now, and fall into an early-generalization. I think a good example of API design has been the IEEE 802.15.4 radio HAL, which took into account multiple heterogeneous hardware and use-cases.
As I see it, introducing a common entropy source API would not invalidate the specific ADC noise API, which could be used to implement the common one. I propose that we move forward with this entropy source as is, leaving the design and evaluation of a common API for upcoming work. This way we can begin to benefit from this feature (and potentially others).
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications