[riot-notifications] [RIOT-OS/RIOT] sys/entropy_source: add new module for entropy sources (#14324)

Marian Buschsieweke notifications at github.com
Wed Nov 25 12:20:09 CET 2020


@maribu commented on this pull request.



> +endchoice
+
+config ENTROPY_SOURCE_ADC_LINE_NUM
+    int "ADC line"
+    range 0 16
+    default 0
+    help
+        The ADC line maps to an I/O pin. This number acts as index to an array
+        of predefined ADC devices that contain the pin definition. Typically,
+        the array is defined by a board in a periph_conf.h file. Please note that
+        a board is not required to specify a minimum number of lines.
+
+config ENTROPY_SOURCE_ADC_HMIN
+    int "Estimated entropy per sample [2^16 * bit/sample]"
+    range 1 524288
+    default 65536

```suggestion
    default 0
```

Having a non-zero default value is a foot gun. Setting the default to zero will force a application developers or board maintainers to override this with a (hopefully) well justified choice.

I bet 99% of the users never read the help message and the warning it contains and just go with the default value. Making the default value defunct will force them to spent the time required on this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14324#pullrequestreview-538396251
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201125/bc6c3f14/attachment.htm>


More information about the notifications mailing list