[riot-notifications] [RIOT-OS/RIOT] Makefile.include: only include serial.inc.mk on term targets (#15477)

Francisco notifications at github.com
Fri Nov 27 10:04:54 CET 2020


@fjmolinas commented on this pull request.



> @@ -1,8 +1,6 @@
 # set default port depending on operating system
 PORT_LINUX ?= /dev/ttyUSB0
 PORT_DARWIN ?= $(firstword $(sort $(wildcard /dev/tty.SLAB_USBtoUART*)))
-# setup serial terminal
-include $(RIOTMAKE)/tools/serial.inc.mk
 
 # setup flash tool
 PROGRAMMER ?= olimex

Just below `PROG_DEV` is used before being set, its a deferred evaluation so it would probably still work but could lead to weird cases.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15477#pullrequestreview-539809557
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201127/acf3df64/attachment.htm>


More information about the notifications mailing list