[riot-notifications] [RIOT-OS/RIOT] Makefile.include: only include serial.inc.mk on term targets (#15477)

Francisco notifications at github.com
Fri Nov 27 10:07:45 CET 2020


@fjmolinas commented on this pull request.

There are still some corner cases to address where `PROG_DEV` is used eventually before being defined:

```
boards/common/esp32/Makefile.include:RESET_FLAGS ?= --port $(PROG_DEV)
boards/common/esp8266/Makefile.include:RESET_FLAGS ?= --port $(PROG_DEV)
boards/common/msb-430/Makefile.include:  MSPDEBUGFLAGS += -d $(PROG_DEV)
boards/common/msba2/Makefile.include:FFLAGS = $(PROG_DEV) $(FLASHFILE)
boards/lobaro-lorabox/Makefile.include:FFLAGS += -p $(PROG_DEV) -e -u -S -l 0x1ff -w $(FLASHFILE)
boards/opencm904/Makefile.include:FFLAGS = $(PROG_DEV) $(FLASHFILE)
boards/telosb/Makefile.include:FFLAGS = --telosb -c $(PROG_DEV) -r -e -I -p $(FLASHFILE)
boards/z1/Makefile.include:FFLAGS = --z1 -I -c $(PROG_DEV) -r -e -p $(FLASHFILE)
cpu/esp_common/Makefile.include:  FFLAGS += --chip $(FLASH_CHIP) --port $(PROG_DEV) --baud $(PROGRAMMER_SPEED)

```



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15477#pullrequestreview-539811604
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201127/1de5f8c4/attachment.htm>


More information about the notifications mailing list