[riot-notifications] [RIOT-OS/RIOT] drivers/{d, e, f}*: add Kconfig modules (#15509)

Leandro Lanzieri notifications at github.com
Fri Nov 27 11:48:09 CET 2020


@leandrolanzieri commented on this pull request.



> +    select MODULE_PERIPH_GPIO
+    select MODULE_PERIPH_PWM
+    select MODULE_XTIMER

For the case of the peripherals it is safe to use `select` given that their dependency is known (the correspondent `HAS_` feature symbol), which is added as a dependency as well to the driver symbol. That way there is no way of selecting a peripheral driver that is not supported.

In the case of Xtimer I chose to make a trade-off given the massive usage of this module. This decision can of course be reviewed, but I found that an user would have to enable Xtimer for so many modules that it would become to much of a hassle. Of course this choice means that we need to keep a close eye if the dependencies of Xtimer happen to change.

Long chains of `select` are not recommended and should be avoided when possible. As `MODULE_UART_HALF_DUPLEX` has dependencies on itself, using a select would be possible if all those dependencies are also moved up to `MODULE_FEETECH`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15509#discussion_r531525430
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201127/ea745606/attachment.htm>


More information about the notifications mailing list