[riot-notifications] [RIOT-OS/RIOT] Add MUD URL option to DHCPv6 client (#15508)

Jan Romann notifications at github.com
Fri Nov 27 11:55:29 CET 2020


@JKRhb commented on this pull request.



> @@ -707,6 +718,23 @@ static void _solicit_servers(event_t *event)
     msg_len += _compose_elapsed_time_opt(time);
     msg_len += _compose_oro_opt((dhcpv6_opt_oro_t *)&send_buf[msg_len], oro_opts,
                                 ARRAY_SIZE(oro_opts));
+
+    #ifdef MUD_URL
+    char mud_url[] = MUD_URL;
+    if (strlen(mud_url) <= 253 && strlen(mud_url) > 0) {

Thank you for all your helpful comments! I have already started to implement them but had some minor problems I wanted to you ask you about. 

As you suggested I tried to added the MUD URL feature in `makefiles/pseudomodules.inc.mk` as a submodule like so:

```c
...
PSEUDOMODULES += gnrc_dhcpv6_%
PSEUDOMODULES += gnrc_dhcpv6_client_mud_url  # the option I added
PSEUDOMODULES += gnrc_ipv6_default
...
```

However, when trying to use the submodule as you suggested, i. e.

```
if (IS_USED(MODULE_GNRC_DHCPV6_CLIENT_MUD_URL)) {
...
}
```

the if condition seems to always evaluate to `true`. Is something else needed to be able to properly use this submodule? (Sorry if I am missing something obvious here.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15508#discussion_r531529260
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201127/8473e1f2/attachment.htm>


More information about the notifications mailing list