[riot-notifications] [RIOT-OS/RIOT] Add MUD URL option to DHCPv6 client (#15508)

benpicco notifications at github.com
Fri Nov 27 16:31:00 CET 2020


@benpicco commented on this pull request.



> @@ -707,6 +718,23 @@ static void _solicit_servers(event_t *event)
     msg_len += _compose_elapsed_time_opt(time);
     msg_len += _compose_oro_opt((dhcpv6_opt_oro_t *)&send_buf[msg_len], oro_opts,
                                 ARRAY_SIZE(oro_opts));
+
+    #ifdef MUD_URL
+    char mud_url[] = MUD_URL;
+    if (strlen(mud_url) <= 253 && strlen(mud_url) > 0) {

> However, when trying to use the pseudo-module as you suggested, i. e.
> 
> ```
> if (IS_USED(MODULE_GNRC_DHCPV6_CLIENT_MUD_URL)) {
> ...
> }
> ```
> 
> the if condition seems to always evaluate to `true`.

even when you are not using the `gnrc_dhcpv6_client_mud_url` module? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15508#discussion_r531663022
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201127/cde24088/attachment-0001.htm>


More information about the notifications mailing list