[riot-notifications] [RIOT-OS/RIOT] Add MUD URL option to DHCPv6 client (#15508)

benpicco notifications at github.com
Fri Nov 27 16:33:10 CET 2020


@benpicco commented on this pull request.



> @@ -27,6 +27,7 @@
 #include "xtimer/implementation.h"
 
 #define ENABLE_DEBUG 0
+#define MAX_MUD_URL_LENGTH 0xFF - sizeof(dhcpv6_opt_mud_url_t)

```suggestion
#define MAX_MUD_URL_LENGTH (0xFF - sizeof(dhcpv6_opt_mud_url_t))
```

Otherwise the result of something like `MAX_MUD_URL_LENGTH * 2` would not be what was commonly expected 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15508#pullrequestreview-540059461
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201127/4bc82df0/attachment.htm>


More information about the notifications mailing list