[riot-notifications] [RIOT-OS/RIOT] Initial implementation of IEEE 802.15.4 security (#15150)

[benpicco]

@benpicco commented on this pull request.



> + * @author      Fabian Hüßler <fabian.huessler at ovgu.de>
+ */
+
+#ifndef INIT_DEVS_H
+#define INIT_DEVS_H
+
+#include "thread.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * @brief   extra stack size if ieee802154 security is enabled
+ */
+#define IEEE802154_SECURITY_EXTRA_STACKSIZE (32)

> Do I still need to increase the stack, or has this fixed the other issue too?

32 byte extra is still too little on RX

```
2020-11-27 23:28:27,852 # 	  5 | udp                  | bl rx    _ |   5 |   1024 (  248) (  776) | 0x20004a94 | 0x20004d9c 
2020-11-27 23:28:27,853 # 	  6 | at86rf215 [sub GHz]  | running  Q |   2 |   1056 ( 1056) (    0) | 0x20001208 | 0x200014ec 
2020-11-27 23:28:27,854 # 	  7 | at86rf215 [2.4 GHz]  | bl rx    _ |   2 |   1056 (  932) (  124) | 0x20001628 | 0x2000190c 
2020-11-27 23:28:27,855 # 	    | SUM                  |            |     |   8768 ( 4124) ( 4644)
2020-11-27 23:28:27,855 # 
2020-11-27 23:28:27,855 # *** halted.
2020-11-27 23:28:27,855 # 
2020-11-27 23:28:27,855 # Inside isr -12
```

with `at86rf215` I see a maximum stack use of 1112 bytes with security enabled and receiving fragmented packets, so `IEEE802154_SECURITY_EXTRA_STACKSIZE` would be 88, maybe round up to 96 or 128?

But the good news it that fragmented packets now work reliably too!



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15150#discussion_r531800244
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201127/56584809/attachment-0001.htm>