[riot-notifications] [RIOT-OS/RIOT] Add MUD URL option to DHCPv6 client (#15508)

Jan Romann notifications at github.com
Sat Nov 28 13:04:34 CET 2020


@JKRhb commented on this pull request.



> @@ -247,6 +247,17 @@ static inline size_t _compose_elapsed_time_opt(dhcpv6_opt_elapsed_time_t *time)
     return len + sizeof(dhcpv6_opt_t);
 }
 
+static inline size_t _compose_mud_url_opt(dhcpv6_opt_mud_url_t *mud_url_opt,
+                                          char mud_url[])
+{
+    uint16_t len = strlen(mud_url);
+
+    mud_url_opt->type = byteorder_htons(DHCPV6_OPT_MUD_URL);
+    mud_url_opt->len = byteorder_htons(len);
+    strcpy(mud_url_opt->mudString, mud_url);

I also noticed that the current buffer length is only 256 Bytes long.

https://github.com/RIOT-OS/RIOT/blob/cfdf30409a664a3d498b68eb4d2ea8697e0bc13c/sys/include/net/dhcpv6/client.h#L48

I assume the length of the send buffer should be increased by 255 Bytes if the `gnrc_dhcpv6_client_mud_url` is used?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15508#discussion_r532032465
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201128/09eacc2b/attachment.htm>


More information about the notifications mailing list