[riot-notifications] [RIOT-OS/RIOT] Add MUD URL option to DHCPv6 client (#15508)

benpicco notifications at github.com
Sun Nov 29 02:08:57 CET 2020


@benpicco commented on this pull request.



> @@ -254,7 +254,7 @@ static inline size_t _compose_mud_url_opt(dhcpv6_opt_mud_url_t *mud_url_opt,
 
     mud_url_opt->type = byteorder_htons(DHCPV6_OPT_MUD_URL);
     mud_url_opt->len = byteorder_htons(len);
-    strncpy(mud_url_opt->mudString, mud_url);
+    strncpy(mud_url_opt->mudString, mud_url, len);

Unfortunately none of the other functions that assemble the request check the size of the buffer :disappointed: 
At least `_add_ia_pd_from_config()` should also be updated with a parameter of the remaining buffer size, so it doesn't silently overflow the request buffer if the MUD URL is long. (should be a separate commit though)

The dhcpv6 client could need some love and cleanup in general 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15508#discussion_r532126410
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201128/a1f5ca39/attachment.htm>


More information about the notifications mailing list