[riot-notifications] [RIOT-OS/RIOT] Add MUD URL option to DHCPv6 client (#15508)
notifications at github.com
Sun Nov 29 03:08:54 CET 2020
@JKRhb commented on this pull request.
> @@ -254,7 +254,7 @@ static inline size_t _compose_mud_url_opt(dhcpv6_opt_mud_url_t *mud_url_opt,
mud_url_opt->type = byteorder_htons(DHCPV6_OPT_MUD_URL);
mud_url_opt->len = byteorder_htons(len);
- strncpy(mud_url_opt->mudString, mud_url);
+ strncpy(mud_url_opt->mudString, mud_url, len);
I agree, there is indeed room for improvement! Would you say that this deserves the opening of an issue?
I added a similar check as you suggested before to the `_add_ia_pd_from_config` function in commit 0299a36 (I hope the commit message is appropriate). Right now, no space in the buffer also causes a crash in this function.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications