[riot-notifications] [RIOT-OS/RIOT] cpu/qn908x: Initial minimal support for NXP QN908x CPUs. (#13855)

benpicco notifications at github.com
Sun Nov 29 18:10:34 CET 2020


@benpicco commented on this pull request.



> +# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+
+config BOARD
+    default "qn9080dk" if BOARD_QN9080DK
+
+config BOARD_QN9080DK
+    bool
+    default y
+    select BOARD_COMMON_QN9080
+    select CPU_MODEL_QN9080XHN
+
+    # Put defined MCU peripherals here (in alphabetical order)
+    select HAS_PERIPH_GPIO
+    select HAS_PERIPH_GPIO_IRQ

>  If the board has no external buttons/gpio/leds etc, would a board with this cpu provide the PERIPH_GPIO feature?

That's a bit of a philosophical question almost ;)
The thing is that a uart or spi implementation might configure GPIOs (e.g. chip select) and GPIOs don't require any configuration, they are always there.
So it doesn't hurt to always advertise GPIO support by the CPU to keep the board code shorter. It's only used if something `FEATURES_REQUIRED += periph_gpio` anyway.

> how about other periphs? (uart, i2c, spi)

Those require some configuration (which pins to use) and they would need to be exposed in order to be useful, so it can only be advertised by the board if they are configured.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13855#discussion_r532238129
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201129/98ace769/attachment-0001.htm>


More information about the notifications mailing list