[riot-notifications] [RIOT-OS/RIOT] cpu/qn908x: Initial minimal support for NXP QN908x CPUs. (#13855)

iosabi notifications at github.com
Sun Nov 29 19:24:06 CET 2020


@iosabi commented on this pull request.



> +# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+
+config BOARD
+    default "qn9080dk" if BOARD_QN9080DK
+
+config BOARD_QN9080DK
+    bool
+    default y
+    select BOARD_COMMON_QN9080
+    select CPU_MODEL_QN9080XHN
+
+    # Put defined MCU peripherals here (in alphabetical order)
+    select HAS_PERIPH_GPIO
+    select HAS_PERIPH_GPIO_IRQ

I'm thinking that an application that implements a blinking LED will set `FEATURES_REQUIRED += periph_gpio` and maybe use them from saul, but it is possible to not compile and include gpio.c in the hello-world application case, even after implementing a uart, i2c and spi drivers. The CS is handled by hardware here too and doesn't involve calling gpio.c code (it does involve setting the mux accordingly, but it is not a GPIO). All of this to say that maybe a board can save some space by not including gpio.c, but it doesn't hurt too much to have it. I moved this to the cpu/. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13855#discussion_r532246941
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201129/9097c869/attachment.htm>


More information about the notifications mailing list