[riot-notifications] [RIOT-OS/RIOT] cpu/qn908x: Initial minimal support for NXP QN908x CPUs. (#13855)

Leandro Lanzieri notifications at github.com
Mon Nov 30 09:22:49 CET 2020


@leandrolanzieri commented on this pull request.

@iosabi thanks for adding the clock configurations with Kconfig, I left some comments on that.

> +config BOARD_COMMON_QN908X
+    bool
+    select CPU_FAM_QN908X
+    # Add common board support here.

The CPU family is already selected by the CPU model symbol, so there is no need to add this.

> +# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+
+config BOARD
+    default "qn9080dk" if BOARD_QN9080DK
+
+config BOARD_QN9080DK
+    bool
+    default y
+    select BOARD_COMMON_QN908X
+    select CPU_MODEL_QN9080XHN
+
+    # Put defined MCU peripherals here (in alphabetical order)
+    select BOARD_HAS_XTAL
+    #select BOARD_XTAL

Forgotten comment?

> @@ -0,0 +1,115 @@
+# Copyright (c) 2020 iosabi
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+
+menu "QN908x clock configuration"
+    depends on CPU_FAM_QN908X
+
+config BOARD_HAS_XTAL32K
+    bool "Board has an external 32.768 KHz crystal"

I think this symbol should not have a prompt, as it is selected and used as interface from the board to indicate that it has a crystal:
```suggestion
    bool
```

> +        32.768 KHz from an external crystal oscillator. This clock can be used
+        to drive the "System clock" for a very low power operation, but it can
+        independently also be used for the watchdog timer (WDT) and other low
+        frequency system timers like a real time clock.
+
+config CPU_CLK_32K_XTAL
+    bool "External 32.768 KHz crystal"
+    depends on BOARD_HAS_XTAL32K
+
+config CPU_CLK_32K_RCO
+    bool "Internal 32 KHz oscillator"
+
+endchoice
+
+config BOARD_HAS_XTAL
+    bool "Board has an external 32 MHz or 16 MHz crystal"

Same here:
```suggestion
    bool
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/13855#pullrequestreview-540664732
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201130/e35ee437/attachment-0001.htm>


More information about the notifications mailing list