[riot-notifications] [RIOT-OS/RIOT] Add MUD URL option to DHCPv6 client (#15508)

benpicco notifications at github.com
Mon Nov 30 11:30:00 CET 2020


@benpicco commented on this pull request.



> @@ -254,7 +254,7 @@ static inline size_t _compose_mud_url_opt(dhcpv6_opt_mud_url_t *mud_url_opt,
 
     mud_url_opt->type = byteorder_htons(DHCPV6_OPT_MUD_URL);
     mud_url_opt->len = byteorder_htons(len);
-    strncpy(mud_url_opt->mudString, mud_url);
+    strncpy(mud_url_opt->mudString, mud_url, len);

> I agree, there is indeed room for improvement! Would you say that this deserves the opening of an issue?

Not sure if an issue would help, I'd rather have a pull request :wink: 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15508#discussion_r532492821
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201130/7d750630/attachment-0001.htm>


More information about the notifications mailing list