[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_ext_frag: check return value of msg_try_send() (#15526)
notifications at github.com
Mon Nov 30 15:37:26 CET 2020
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Addresses parts of #15521. Not checking the return value of `msg_try_send()` could indeed lead to a leak in the packet buffer.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
I tried to provide tests for the corner case, but RIOT makes it quite hard to mock filled message queues :-/. However, `tests/gnrc_ipv6_ext_frag` should still pass never the less **NOTE THE SUDO! This test is not run on Murdock**:
sudo ./dist/tools/tapsetup/tapsetup # if you haven't already opened a TAP interface
make -C tests/gnrc_ipv6_ext_frag -j
sudo make -C tests/gnrc_ipv6_ext_frag test
Of course this also should work with any board supporting `ethos`.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Addresses parts of #15521
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* gnrc_ipv6_ext_frag: check return value of msg_try_send()
-- File Changes --
M sys/net/gnrc/network_layer/ipv6/ext/frag/gnrc_ipv6_ext_frag.c (12)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications