[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_ext_frag: check return value of msg_try_send() (#15526)

Martine Lenders notifications at github.com
Mon Nov 30 20:09:42 CET 2020


@miri64 commented on this pull request.



> @@ -291,13 +300,13 @@ static void _snd_buf_del(gnrc_ipv6_ext_frag_send_t *snd_buf)
     snd_buf->pkt = NULL;
 }
 
-static void _snd_buf_free(gnrc_ipv6_ext_frag_send_t *snd_buf)
+static void _snd_buf_free(gnrc_ipv6_ext_frag_send_t *snd_buf, int errno)
 {
     if (snd_buf->per_frag) {
         gnrc_pktbuf_release(snd_buf->per_frag);

`per_frag` is derived from `pkt`, so I don't think that is necessary. A subscriber would then only get duplicate messages:

https://github.com/RIOT-OS/RIOT/blob/3234b918e361d273b9cfef3c123653b174f0abc0/sys/net/gnrc/network_layer/ipv6/ext/frag/gnrc_ipv6_ext_frag.c#L112-L127

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15526#discussion_r532833550
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201130/12ff7172/attachment-0001.htm>


More information about the notifications mailing list