[riot-notifications] [RIOT-OS/RIOT] Add MUD URL option to DHCPv6 client (#15508)

benpicco notifications at github.com
Mon Nov 30 21:39:02 CET 2020


@benpicco commented on this pull request.

Looks good to me - one more thing though: Kconfig needs a tunable to actually enable the module. 

> @@ -16,4 +16,7 @@ config DHCPV6_CLIENT_PFX_LEASE_MAX
     int "Maximum number of prefix leases to be stored"
     default 1
 

```suggestion

menuconfig KCONFIG_USEMODULE_GNRC_DHCPV6_CLIENT_MUD_URL
    bool "Enable DHCPv6 Client MUD URL"
    help
        Short text why you would want this

if KCONFIG_USEMODULE_GNRC_DHCPV6_CLIENT_MUD_URL
```

> @@ -16,4 +16,7 @@ config DHCPV6_CLIENT_PFX_LEASE_MAX
     int "Maximum number of prefix leases to be stored"
     default 1
 
+config CONFIG_DHCPV6_CLIENT_MUD_URL
+    string "URL pointing to a Manufacturer Usage Description file"
+
 endif # KCONFIG_USEMODULE_DHCPv6

```suggestion
endif # KCONFIG_USEMODULE_GNRC_DHCPV6_CLIENT_MUD_URL
endif # KCONFIG_USEMODULE_DHCPv6
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15508#pullrequestreview-541275032
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20201130/0503ee73/attachment.htm>


More information about the notifications mailing list