[riot-notifications] [RIOT-OS/RIOT] sys/ztimer: add ZTIMER_SEC, improve auto_init (#16172)

Marian Buschsieweke notifications at github.com
Thu Apr 1 16:42:06 CEST 2021


@maribu commented on this pull request.

Some typos, you can directly squash. (Ideally even before pushing.)

Note: If you split out the last two commits, they could go in right away.

> @@ -154,8 +173,8 @@ int rtc_get_time(struct tm *ttime)
     }
     _native_syscall_leave();
 
-    /* riot does not handle dst */
-    ttime->tm_isdst=0;
+    /* RIoT does not handle DST or TZ information */

```suggestion
    /* RIOT does not handle DST or TZ information */
```

>  
+    /* mktime() and localtime are only inverse fuctions if tm_idst ==-1 */

```suggestion
    /* mktime() and localtime are only inverse functions if tm_idst ==-1 */
```

> @@ -53,6 +53,19 @@ static void _native_rtc_cb(void *arg) {
     _native_rtc_alarm_callback = NULL;
 }
 
+/* RIoT does not expect DST or TZ information */

```suggestion
/* RIOT does not expect DST or TZ information */
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16172#pullrequestreview-626336567
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210401/ee5e712e/attachment-0001.htm>


More information about the notifications mailing list