[riot-notifications] [RIOT-OS/RIOT] sys/crypto: Enable support for AES-192, AES-256 (#16183)

Leandro Lanzieri notifications at github.com
Wed Apr 7 09:27:26 CEST 2021


@leandrolanzieri commented on this pull request.



> @@ -298,6 +298,9 @@ PSEUDOMODULES += skald_eddystone
 # define optimized read function of DS18 driver as a pseudo module
 PSEUDOMODULES += ds18_optimized
 
+PSEUDOMODULES += crypto_aes_128

> Can you give an example of how this would work with DEFAULT_MODULE ? I can't find any documentation about it.

https://github.com/RIOT-OS/RIOT/blob/569e299e63dc7dd132ff528b02b4c1a76d43f563/sys/Makefile.dep#L787-L788
What's added to `DEFAULT_MODULE` can be disabled by `DISABLE_MODULE`.

> Why would this approach be better than my approach of setting `MODULE_CRYPTO_AES_128` if none of the pseudomodules has been specified ?

Because just defining a macro on a specific header file is not the same as activating a module. The build system is in charge of resolving this dependencies, because it can affect other modules, configurations or even bring in other dependencies. The `MODULE_` macros are injected via `riotbuild.h`, so they are available at compilation to all modules, even if they don't include the ciphers header file.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16183#discussion_r608405473
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210407/4b675337/attachment.htm>


More information about the notifications mailing list