[riot-notifications] [RIOT-OS/RIOT] driver/sgp30: initial import (#16222)

Koen Zandberg notifications at github.com
Wed Apr 7 09:43:12 CEST 2021


@bergzand commented on this pull request.

Some initial nitpicks!

> + * @author      Francisco Molina <francois-xavier.molina at inria.fr>
+ */
+
+#ifndef SGP30_H
+#define SGP30_H
+
+#include "periph/i2c.h"
+#include "ztimer.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * @brief     Set of measured values
+ *

Duplicate newline

> + * @brief     Set of measured values
+ *
+ */
+typedef struct {
+    uint16_t tvoc;      /**< The last measurement of the IAQ-calculated Total
+                             Volatile Organic Compounds in ppb. */
+    uint16_t eco2;      /**< The last measurement of the IAQ-calculated
+                             equivalent CO2 in ppm */
+#ifdef MODULE_SGP30_STRICT
+    uint32_t timestamp; /**< Timestamp of last measured value */
+#endif
+} sgp30_data_t;
+
+/**
+ * @brief     Set of measured raw values
+ *

And another

> + *                         humidity compensation, max value is 255999 mg/m3.
+ *
+ * @retval  0         Success
+ * @retval -PROTO     Sensor did not acknowledge command
+ */
+int sgp30_set_absolute_humidity(sgp30_t *dev, uint32_t humidity);
+
+/**
+ * @brief   Set new baseline values
+ *
+ * @param[in]   dev        Device descriptor of the driver
+ * @param[in]   data       Baseline values to be set
+ *
+ * @retval  0         Success
+ * @retval -PROTO     Sensor did not acknowledge command
+ *

Another one :(

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16222#pullrequestreview-629683126
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210407/9941bca1/attachment.htm>


More information about the notifications mailing list