[riot-notifications] [RIOT-OS/RIOT] drivers/sm_pwm_01c: initial import (#16217)
notifications at github.com
Wed Apr 7 10:24:14 CEST 2021
@leandrolanzieri commented on this pull request.
Some minor comments @fjmolinas, also can you check some warnings from the static tests that appear in the code view? Feel free to squash directly.
> + sm_pwm_01c_params_t params; /**< Device driver parameters */
+ sm_pwm_01c_values_t _values; /**< Internal data to calculate concentration
+ from tsl/tsp low Pulse Output Occupancy */
+ ztimer_t _sampler; /**< internal sampling timer */
+ * @brief Initialize the given SM_PWM_01C device
+ * @param[out] dev Initialized device descriptor of SM_PWM_01C device
+ * @param[in] params The parameters for the SM_PWM_01C device
+ * @retval 0 on success
+ * @retval -EIO GPIO error
+int sm_pwm_01c_init(sm_pwm_01c_t* dev, const sm_pwm_01c_params_t* params);
Just a nitpick, but I think we usually mostly write:
int sm_pwm_01c_init(sm_pwm_01c_t *dev, const sm_pwm_01c_params_t *params);
> + * @author Francisco Molina <francois-xavier.molina at inria.fr>
+ * @}
+#define ENABLE_DEBUG (0)
#define ENABLE_DEBUG 0
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications