[riot-notifications] [RIOT-OS/RIOT] boards/nucleo-wl55jc : Initial support (#16255)

MrKevinWeiss notifications at github.com
Wed Apr 7 14:09:37 CEST 2021


@MrKevinWeiss requested changes on this pull request.

Some small issues while running through the HiL testing.

> +### MCU
+
+
+| MCU        |   STM32WL55JC                                             |
+|:---------- |:--------------------------------------------------------- |
+| Family     | ARM Cortex-M4 / ARM Cortex-M0+ Dual core                  |
+| Vendor     | ST Microelectronics                                       |
+| RAM        | 64KiB                                                     |
+| Flash      | 256KiB                                                    |
+| Frequency  | up to 48MHz                                               |
+| FPU        | no                                                        |
+| Timers     | 10 (2x watchdog, 1 SysTick, 6x 16-bit, 1x 32-bit [TIM2])  |
+| ADCs       | 1x 12-bit (12 channel )                                   |
+| UARTs      | 3 (two UARTs and one Low-Power UART)                      |
+| SPIs       | 2                                                         |
+| I2Cs       | 3                                                         |

Are we saying how many the chip has or how many are available in RIOT? (I don't know).  As I count it there is 1.

> + */
+static const i2c_conf_t i2c_config[] = {
+    {
+        .dev            = I2C1,
+        .speed          = I2C_SPEED_NORMAL,
+        .scl_pin        = GPIO_PIN(PORT_A, 12),
+        .sda_pin        = GPIO_PIN(PORT_A, 11),
+        .scl_af         = GPIO_AF4,
+        .sda_af         = GPIO_AF4,
+        .bus            = APB1,
+        .rcc_mask       = RCC_APB1ENR1_I2C1EN,
+        .irqn           = I2C1_ER_IRQn,
+    }
+};
+
+#define I2C_0_ISR           isr_i2c1_erq

```suggestion
#define I2C_0_ISR           isr_i2c1_erq

#define I2C_NUMOF           ARRAY_SIZE(i2c_config)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16255#pullrequestreview-629925420
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210407/6f328a9b/attachment.htm>


More information about the notifications mailing list