[riot-notifications] [RIOT-OS/RIOT] [PoC] drivers/at86rf215: allow MR-O-QPSK & legacy O-QPSK at the same time (#16312)

José Alamos notifications at github.com
Mon Apr 12 09:31:51 CEST 2021


@jia200x requested changes on this pull request.



> @@ -290,12 +292,56 @@ int at86rf215_tx_prepare(at86rf215_t *dev)
     return 0;
 }
 
+static void _mr_oqpsk_set_mode(at86rf215_t *dev, const uint8_t *data)
+{
+#ifdef MODULE_AT86RF215_MR_OQPSK_MULTIRATE
+    uint8_t addr[8];
+    le_uint16_t pan;
+    int addr_len;
+    netstats_nb_t stats;
+    gnrc_netif_t *netif;
+
+    if (dev->oqpsk_phr_default == 0) {
+        return;
+    }
+
+    addr_len = ieee802154_get_dst(data, addr, &pan);
+    netif = gnrc_netif_get_by_netdev(&dev->netdev.netdev);

This adds a dependency in the driver to GNRC.
Please try to move everything that doesn't belong to these layer to the upper layer and only leave here the hardware specific parts. Otherwise we might have issues with other stacks

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16312#pullrequestreview-633216355
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210412/e1939e02/attachment.htm>


More information about the notifications mailing list