[riot-notifications] [RIOT-OS/RIOT] boards/nucleo-wl55jc : Initial support (#16255)

Alexandre Abadie notifications at github.com
Wed Apr 14 14:44:28 CEST 2021


@aabadie commented on this pull request.

Found some minor stuff and the Kconfig files are missing for the CPU part. You can have a look at https://github.com/aabadie/RIOT/tree/stm32wl/cpu/stm32/kconfigs/wl (the Kconfig.lines and Kconfig.models are generated using https://github.com/RIOT-OS/RIOT/tree/master/cpu/stm32/dist/kconfig



> +    # Clock configuration
+    select BOARD_HAS_HSE
+

This is not needed since `BOARD_HAS_HSE` is already selected in the common nucleo64 Kconfig which is included just below:

https://github.com/RIOT-OS/RIOT/blob/a8e9fa6253bc8275111a292b110d108825e6ce71/boards/common/nucleo64/Kconfig#L12-L14

> @@ -339,7 +339,9 @@
 #define CLOCK48MHZ_USE_MSI          0
 #endif
 
-#if IS_ACTIVE(CLOCK48MHZ_USE_PLLQ)
+#if defined(CPU_FAM_STM32WL)

Instead of adding a specific case for stm32wl here, I would just modify line 335 as follows:
```
#elif CONFIG_CLOCK_MSI == MHZ(48) && !defined(CPU_FAM_STM32WL)
```

Then both CLOCK48MHZ_USE_PLLQ and CLOCK48MHZ_USE_MSI will be 0 (according to the manual there's no specific 48MHz clock on stm32wl).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16255#pullrequestreview-635544110
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210414/9fd8e656/attachment.htm>


More information about the notifications mailing list