[riot-notifications] [RIOT-OS/RIOT] core/clist: add special cardinality tests and matching unittest (#16330)

Kaspar Schleiser notifications at github.com
Wed Apr 14 15:51:38 CEST 2021

@kaspar030 requested changes on this pull request.

doxygen nitpick, looks good otherwise

> @@ -466,6 +468,38 @@ static inline size_t clist_count(clist_node_t *list)
     return cnt;
+ * @brief   Tells if a list has exactly one element
+ *
+ * @note    Complexity: O(1)
+ *
+ * @param[in]   list    Pointer to the clist
+ *
+ * @return      Cardinality == 1 information

here and below: please drop the "@return", and rename "@retval" to "@returns".

The former because IMO, return and retval are redundant.
The latter because the rest of the file uses `@returns`, and if we want to fix that, we should do all in one go and until then keep it consistent.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210414/138c7dea/attachment-0001.htm>

More information about the notifications mailing list