[riot-notifications] [RIOT-OS/RIOT] sys/crypto: Enable support for AES-192, AES-256 (#16183)

Leandro Lanzieri notifications at github.com
Thu Apr 15 10:54:35 CEST 2021


@leandrolanzieri commented on this pull request.



> @@ -298,6 +298,9 @@ PSEUDOMODULES += skald_eddystone
 # define optimized read function of DS18 driver as a pseudo module
 PSEUDOMODULES += ds18_optimized
 
+PSEUDOMODULES += crypto_aes_128

`crypto_aes` is now `crypto_aes_128`, that should be changed in the `Makefile.dep`s.

> @@ -298,6 +298,9 @@ PSEUDOMODULES += skald_eddystone
 # define optimized read function of DS18 driver as a pseudo module
 PSEUDOMODULES += ds18_optimized
 
+PSEUDOMODULES += crypto_aes_128

Also https://github.com/RIOT-OS/RIOT/blob/master/sys/crypto/Kconfig needs to be updated. Some tests are failing because of this. I think something like the following should work:
```difff
diff --git a/sys/crypto/Kconfig b/sys/crypto/Kconfig
index fa070b10c1..ce99ad759a 100644
--- a/sys/crypto/Kconfig
+++ b/sys/crypto/Kconfig
@@ -19,18 +19,24 @@ choice
         The common Crypto block ciphers API has multiple implementations. Choose
         one of the following.
 
-config MODULE_CRYPTO_AES
+config CRYPTO_AES
     bool "AES"
     select MODULE_CRYPTO
 
-config MODULE_CRYPTO_3DES
-    bool "3DES (deprecated)"
-    select MODULE_CRYPTO
-
 endchoice
 
 menu "Crypto AES options"
-depends on MODULE_CRYPTO_AES
+depends on CRYPTO_AES
+
+config MODULE_CRYPTO_AES_128
+    bool "AES-128"
+    default y
+
+config MODULE_CRYPTO_AES_192
+    bool "AES-192"
+
+config MODULE_CRYPTO_AES_256
+    bool "AES-256"
 
 config MODULE_CRYPTO_AES_PRECALCULATED
     bool "Pre-calculate T tables"
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16183#pullrequestreview-636430161
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210415/b4effbb9/attachment-0001.htm>


More information about the notifications mailing list