[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: auto-configure downstream subnets (#16536)

Martine Lenders notifications at github.com
Wed Aug 4 12:03:52 CEST 2021


@miri64 requested changes on this pull request.



> @@ -86,6 +86,14 @@ static void _handle_rdnss_timeout(sock_udp_ep_t *dns_server);
 #endif
 /** @} */
 
+/* Callback to hook into Prefix Information Option */
+__attribute__ ((weak))
+void gnrc_nib_rtr_adv_pio_cb(gnrc_netif_t *netif, const ndp_opt_pi_t *pio)

```suggestion
void gnrc_ipv6_nib_rtr_adv_pio_cb(gnrc_netif_t *netif, const ndp_opt_pi_t *pio)
```

> +/**
+ * @brief   Immediately send a 'last router advertisement', that is a RA that
+ *          does not advertise this host as a default router.
+ *
+ *          If the @ref CONFIG_GNRC_IPV6_NIB_ADD_RIO_IN_LAST_RA option is set,
+ *          this will include a Route Information Option and nothing else.
+ *
+ * @param[in] netif     The interface on which the router advertisement should
+ *                      be sent.
+ */
+void gnrc_ipv6_nib_send_final_rtr_adv(gnrc_netif_t *netif);

Why is this function needed? Shouldn't it be enough to disable `RTR_ADV` on the interface?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16536#pullrequestreview-722097026
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210804/a983f361/attachment.htm>


More information about the notifications mailing list