[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: auto-configure downstream subnets (#16536)

Martine Lenders notifications at github.com
Wed Aug 4 12:24:57 CEST 2021


@miri64 requested changes on this pull request.



> +    /* Disable router advertisements on upstream interface.
+     * 1. Does not confuse the upstream router to add the border router to its
+     *    default router list and
+     * 2. Includes Route Information Option in last router advertisement to
+     *    inform upstream router about downstream subnets.
+     */
+    gnrc_ipv6_nib_send_final_rtr_adv(upstream);

```suggestion
    /* Immediately send an RA with RIO
     */
    gnrc_pktsnip_t *ext_opts = NULL;

    while (/* use gnrc_ipv6_nib_pl_iter to get PL entries */) {
            gnrc_pktsnip_t *snip  = gnrc_ndp_opt_ri_build(&ple.pfx,
                                                          ple.pfx_len,
                                                          valid_ltime,
                                                          NDP_OPT_RI_FLAGS_PRF_NONE,
                                                          ext_opts);
            if (snip != NULL) {
                ext_opts = snip;
            } else {
                break;
            }
    }

    gnrc_ndp_rtr_adv_send(netif, NULL, &ipv6_addr_all_nodes_link_local,
                          true, ext_opts);
```

> +/**
+ * @brief   Immediately send a 'last router advertisement', that is a RA that
+ *          does not advertise this host as a default router.
+ *
+ *          If the @ref CONFIG_GNRC_IPV6_NIB_ADD_RIO_IN_LAST_RA option is set,
+ *          this will include a Route Information Option and nothing else.
+ *
+ * @param[in] netif     The interface on which the router advertisement should
+ *                      be sent.
+ */
+void gnrc_ipv6_nib_send_final_rtr_adv(gnrc_netif_t *netif);

In that case https://github.com/RIOT-OS/RIOT/pull/16536#discussion_r682475480 still applies.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16536#pullrequestreview-722106350
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210804/a1b81342/attachment.htm>


More information about the notifications mailing list