[riot-notifications] [RIOT-OS/RIOT] usbus/hid_io: add missing header file, add RX callback function (#16689)

Nils Ollrogge notifications at github.com
Wed Aug 4 13:28:39 CEST 2021


@Ollrogge commented on this pull request.



>  }
 
 void usb_hid_io_init(usbus_t *usbus, uint8_t *report_desc,
                      size_t report_desc_size)
 {
     usbus_hid_init(usbus, &hid, _hid_rx_pipe,  report_desc, report_desc_size);
 }
+
+void usb_hid_io_set_rx_cb(usb_hid_io_t *usb_hid_io)

No. `usb_hid_io_init` is called to initialize the USB layer. I want the callback functionality to be an additional, not necessarily required, functionality. Possibly the naming of the struct is bad as it suggests that this struct is supposed to be used in a more genral context than just for the callback functionality.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16689#discussion_r682528593
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210804/fb026936/attachment-0001.htm>


More information about the notifications mailing list