[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: consider fib when deciding if host on-link (#16557)

Martine Lenders notifications at github.com
Sat Aug 7 13:58:50 CEST 2021


@miri64 commented on this pull request.



> @@ -178,15 +179,25 @@ static bool _on_link(const ipv6_addr_t *dst, unsigned *iface)
     }
 #endif  /* CONFIG_GNRC_IPV6_NIB_6LN */
     while ((entry = _nib_offl_iter(entry))) {
-        if ((entry->mode & _PL) && (entry->flags & _PFX_ON_LINK) &&
-            (ipv6_addr_match_prefix(dst, &entry->pfx) >= entry->pfx_len) &&

Maybe the problem is that this should rather be a `==` or `<=` and that is why you get the wrong prefixes reported as on-link?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16557#pullrequestreview-724815203
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210807/f412571c/attachment.htm>


More information about the notifications mailing list