[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: Add IA_NA support to the DHCPv6 client (#16228)

Jan Romann notifications at github.com
Mon Aug 9 20:27:56 CEST 2021


@JKRhb commented on this pull request.



> +    if (!IS_USED(MODULE_DHCPV6_CLIENT_IA_NA)) {
+        return;
+    }
+
+    /* If no specific interface ID is given, check all
+       interfaces if DHCP IA_NA is enabled. Otherwise
+       use the specific interface ID. */
+    if (netif == SOCK_ADDR_ANY_NETIF) {
+        netif_t* netif = NULL;
+        while ((netif = netif_iter(netif))) {
+            int16_t netif_id = netif_get_id(netif);
+            if (netif_id < 0) {
+                continue;
+            }
+            if (dhcpv6_client_check_ia_na(netif_id)) {
+                dhcpv6_client_req_ia_na(netif_id);

Would printing a debug message be enough if `dhcpv6_client_req_ia_na` returns a value < 0? Or should there be some kind of assertion or error handling?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16228#discussion_r685425178
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210809/878c7a61/attachment.htm>


More information about the notifications mailing list