[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: Add IA_NA support to the DHCPv6 client (#16228)

Martine Lenders notifications at github.com
Tue Aug 10 06:44:14 CEST 2021


@miri64 commented on this pull request.



> + * @param[in] netif     Network interface the address was for.
+ * @param[in] addr      The address to deprecate.
+ *
+ * @return  true, if the address was deprecated successfully.
+ */
+bool dhcpv6_client_deprecate_addr(unsigned netif, const ipv6_addr_t *addr);
+
+/**
+ * @brief   Removes an existing address that originated from an address lease.
+ *
+ * @param[in] netif     Network interface the address was for.
+ * @param[in] addr      The address to remove.
+ *
+ * @return  true, if the address was removed successfully.
+ */
+bool dhcpv6_client_remove_addr(unsigned netif, ipv6_addr_t *addr);

Ah, this is because it is used with `gnrc_netapi_set()` where in turn it is used to set a pointer in an `msg_t`. So even though it _could_ be used as `const` (the `NETAPI_SET` routine of `gnrc_netif` treats it as an input pointer), doing so would probably still through some warnings in the compiler, even when explicitly casted, depending on the level of warnings. So I agree to leave it as is.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16228#discussion_r685685699
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210809/32989811/attachment.htm>


More information about the notifications mailing list