[riot-notifications] [RIOT-OS/RIOT] gnrc_sock_tcp: add gnrc sock tcp (#16494)

benpicco notifications at github.com
Tue Aug 10 10:30:08 CEST 2021


@benpicco commented on this pull request.



> +    dump_args(argc, argv);
+    sock_tcp_disconnect(sock);
+    printf("%s: returns\n", argv[0]);

```suggestion
    sock_tcp_disconnect(sock);
```

No need to be so verbose ;) 

> +    dump_args(argc, argv);
+

```suggestion
    if (argc < 2) {
        printf("usage: %s <host> <port>\n", argv[0]);
        return -1;
    }
 ```

let's be a bit more user friendly. Right now if you just call `gnrc_tcp_open` expecting to get usage information, the test will just crash on you.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16494#pullrequestreview-726150895
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210810/850ca08d/attachment.htm>


More information about the notifications mailing list