[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: Add IA_NA support to the DHCPv6 client (#16228)

Martine Lenders notifications at github.com
Tue Aug 10 18:45:52 CEST 2021


@miri64 commented on this pull request.



>      dhcpv6_client_start();
     event_loop(&event_queue);   /* never returns */
     return NULL;
 }
 #endif /* MODULE_AUTO_INIT_DHCPV6_CLIENT */
 
+void _print_ia_na_debug_info(uint16_t netif, int result_code)
+{
+    if (result_code == 0) {
+        return;
+    } else if (result_code == -ENOMEM) {

```suggestion
    } else {
```

should suffice with a corresponding update to the DEBUG message. When DEBUG is enabled, the user should know by now, that IA_NA is not enabled, so they can draw their own conclusion what the problem may and we safe a check ;-).

> +}
+
+int dhcpv6_client_add_addr(unsigned iface, ipv6_addr_t *addr)
+{
+    gnrc_netif_t *netif = gnrc_netif_get_by_pid(iface);
+
+    DEBUG("DHCPv6 client: ADD IP ADDRESS\n");
+
+    return gnrc_netif_ipv6_addr_add(netif, addr, 64, 0);
+}
+
+void dhcpv6_client_deprecate_addr(unsigned iface, const ipv6_addr_t *addr)
+{
+    gnrc_netif_t *netif = gnrc_netif_get_by_pid(iface);
+    int i;
+    

```suggestion

```

> @@ -8,13 +8,22 @@
 
 import sys
 from testrunner import run
+from ipaddress import(

```suggestion
from ipaddress import (
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16228#pullrequestreview-726609003
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210810/95037421/attachment.htm>


More information about the notifications mailing list