[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: Add IA_NA support to the DHCPv6 client (#16228)

Martine Lenders notifications at github.com
Tue Aug 10 19:05:36 CEST 2021

@miri64 commented on this pull request.

> +    gnrc_netif_acquire(netif);
+    i = gnrc_netif_ipv6_addr_idx(netif, addr);
+    if (i >= 0) {
+        netif->ipv6.addrs_flags[i] &= ~GNRC_NETIF_IPV6_ADDRS_FLAGS_STATE_MASK;
+        netif->ipv6.addrs_flags[i] |= GNRC_NETIF_IPV6_ADDRS_FLAGS_STATE_DEPRECATED;
+    }
+    gnrc_netif_release(netif);
+bool dhcpv6_client_remove_addr(unsigned iface, ipv6_addr_t *addr)
+    gnrc_netif_t *netif = gnrc_netif_get_by_pid(iface);
+    gnrc_netif_ipv6_addr_remove(netif, addr);
+    return false;

I actually would just not return anything. The return value of `gnrc_netif_ipv6_addr_remove()` is just passed from `gnrc_netapi_set()`, but IIRC that only fails if something is wrong with the input parameters (which `gnrc_netif_ipv6_addr_remove()` will assure that they won't). So either way, I don't think a debug message is necessary here.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210810/91a69eaf/attachment-0001.htm>

More information about the notifications mailing list