[riot-notifications] [RIOT-OS/RIOT] FIDO2 support in RIOT (#16489)

Nils Ollrogge notifications at github.com
Wed Aug 11 09:27:39 CEST 2021

@Ollrogge commented on this pull request.

> +                 # dev.control_exchange(SCARD_CTL_CODE(0x3500), b"\xE0\x00\x00\x24\x02\x00\x00")
++        '''
+         if not dev:
+             raise RuntimeError("No FIDO device found")
+diff --git a/tests/standard/fido2/pin/test_pin.py b/tests/standard/fido2/pin/test_pin.py
+index 78b09e3..f5ee4e4 100644
+--- a/tests/standard/fido2/pin/test_pin.py
++++ b/tests/standard/fido2/pin/test_pin.py
+@@ -60,7 +60,11 @@ class TestPin(object):
+         with pytest.raises(CtapError) as e:
+             device.client.pin_protocol.set_pin('1234')
+-        assert e.value.code == CtapError.ERR.NOT_ALLOWED
++        '''
++        CTAP spec states: "If a PIN has already been set, authenticator

Yes I would say it is. I understand the spec differently than they do. Will open an issue upstream and try to discuss.
No this does not relate to user presence test.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210811/51d22ad2/attachment-0001.htm>

More information about the notifications mailing list