[riot-notifications] [RIOT-OS/RIOT] sys/shell/commands/gnrc_icmpv6_echo: test for ICMPv6 reply corruption (#15622)

Martine Lenders notifications at github.com
Wed Aug 11 11:15:40 CEST 2021


@miri64 commented on this pull request.



>          if (data->datalen >= sizeof(uint32_t)) {
-            triptime = xtimer_now_usec() - unaligned_get_u32(icmpv6_hdr + 1);

How is trip-time set now for the checks below? From what I can tell it is only set in `_check_payload()` which is called _after_ these lines. At least for the first message the RTT will now be wrong.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15622#pullrequestreview-727245969
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210811/9036d247/attachment-0001.htm>


More information about the notifications mailing list