[riot-notifications] [RIOT-OS/RIOT] sys/shell/commands/gnrc_icmpv6_echo: test for ICMPv6 reply corruption (#15622)

Martine Lenders notifications at github.com
Wed Aug 11 11:47:52 CEST 2021


@miri64 commented on this pull request.



>          if (rssi != GNRC_NETIF_HDR_NO_RSSI) {
             printf(" rssi=%"PRId16" dBm", rssi);
         }
         if (data->datalen >= sizeof(uint32_t)) {
             printf(" time=%lu.%03lu ms", (long unsigned)triptime / 1000,
                    (long unsigned)triptime % 1000);
         }
+
+        /* we can only calculate RTT if payload was large enough for TX timestamp */

```suggestion
        /* we can only calculate RTT if payload was large enough for TX timestamp
         * (the basis of triptime) */
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15622#pullrequestreview-727277982
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210811/f879f8de/attachment.htm>


More information about the notifications mailing list