[riot-notifications] [RIOT-OS/RIOT] sys/net/nanocoap: block_finish returns if more are expected (#16704)

Martine Lenders notifications at github.com
Wed Aug 11 12:14:33 CEST 2021


@miri64 commented on this pull request.



> @@ -1032,10 +1032,12 @@ void coap_block_finish(coap_block_slicer_t *slicer, uint16_t option)
     uint8_t *pos = slicer->opt + 1;
     uint16_t delta = _decode_value(*slicer->opt >> 4, &pos, slicer->opt + 3);
 
-    uint32_t blkopt = _slicer2blkopt(slicer, slicer->cur > slicer->end);
+    bool more = slicer->cur > slicer->end;

(That might be only the problem when `slicer` is used outside the context of this function, but it was not always the value I thought it was, so in #16705 I ended up just using `slicer->end < buf_len` as `more` condition).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16704#discussion_r686693468
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210811/0d471ec1/attachment.htm>


More information about the notifications mailing list